Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Use task label if is set #1145

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Tools: Use task label if is set #1145

merged 3 commits into from
Feb 12, 2025

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 12, 2025 •
edited
Loading

Changelog Description

Use task label in UIs if is set on entity.

Additional info

Before this PR only task name was shown in UIs and label was ignored.

Testing notes:

  1. Set label on task to something else from name.
  2. Open UI showing tasks (e.g. launcher).
  3. The task should show the label set on entity.

Resolves #1004

@ynbot ynbot added the size/XS label Feb 12, 2025
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Feb 12, 2025
@iLLiCiTiT iLLiCiTiT self-assigned this Feb 12, 2025
@iLLiCiTiT iLLiCiTiT changed the title UI: Use task label if is set Tools: Use task label if is set Feb 12, 2025
BigRoy
BigRoy approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Nice.

image

LiborBatek
LiborBatek approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

My entity and its label for task type set:
Screenshot 2025-02-12 163903

Once setting the context within the Launcher:

Screenshot 2025-02-12 163952

@iLLiCiTiT iLLiCiTiT merged commit 8888819 into develop Feb 12, 2025
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/1004-launcher-show-task-label-if-set-instead-of-name branch February 12, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@64qam 64qam 64qam approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

@MilaKudr MilaKudr MilaKudr approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launcher: Show task label if set instead of name
6 participants
@iLLiCiTiT @BigRoy @64qam @LiborBatek @MilaKudr @ynbot