generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Deadline Submission JobInfo #49
Open
kalisp
wants to merge
143
commits into
develop
Choose a base branch
from
feature/AY-6789_Render-instance-support-of-Frame-List
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
143 commits
Select commit
Hold shift + click to select a range
d1a883b
New Settings for CollectJobInfoItem
kalisp f72e87f
Matched implemented artist overrides definitions
kalisp 2b29403
Added collected jobInfo object
kalisp cb0d24d
Use DeadlineJobInfo as collector object
kalisp 37c0a0d
Removed six dependency
kalisp 3358838
Implemented new generic method applicable for all DCC
kalisp 60da8b9
Removed unneeded imports
kalisp ae3c739
Do not pass empty string to DeadlineJobInfo
kalisp 1c8990a
Removed unneded imports
kalisp 57860ce
Reimplemented get_job_info, moved to generic impl
kalisp 10f566f
Removed storign deadline info to instance
kalisp bbb12b7
Updates to DeadlineJobInfo to match previous implementation
kalisp c26c997
Added Frames field for explicit rendering
kalisp e1eba7f
Run CollectJobInfo only locally
kalisp 8062462
Implemented explicit frames filtering on simple files
kalisp ec908e0
Reworked removal of deadline in submit job
kalisp 64b22ff
Removed empty line
kalisp 0d3125d
Added empty line at the end
kalisp c206b24
Formatting
kalisp 803c25c
Removed forgotten dev code
kalisp 201c5b8
Refactor batchname
kalisp 57ac094
Merge develop
kalisp 6a280b0
Added last empty line
kalisp 6d3fe14
Changed collection of project_settings
kalisp f09cde7
Removed hiding attributes on disabled instances
kalisp 47f0f8b
Replaced querying with cached methods
kalisp 3ae7c94
Fixed handling of list defaults
kalisp 41e2f03
Refactor defs initialization
kalisp 8227376
Fix instance variable
kalisp 24dbf6d
Formatting
kalisp 87d5f4b
Refactored base definition to array
kalisp 2fbc45b
Fix default values for not existing task entity
kalisp c6416ad
Removed unnecessary condition
kalisp e593e5d
Separated AYON fields from Deadline own
kalisp dfa544b
Updates to limit_groups, machine lists
kalisp ac77178
Updated machine_limit handling
kalisp 068ae90
Updated expected_files handling
kalisp 0e3760a
Implemented additional JobInfo, PluginInfo fields
kalisp 26a63d0
Refactor
kalisp 1352ad0
Removed unneeded variable
kalisp 1e9a349
Refactored querying of profiles
kalisp a692796
Refactor
kalisp 67de670
Refactored task values
kalisp 834290a
Merge remote-tracking branch 'origin/feature/AY-6789_Render-instance-…
kalisp dbd9304
Removed magic conversion from Settings to fields
kalisp 5fa1034
Implemented UsePublished
kalisp 6330f07
Removed unneeded default_priority
kalisp 7221315
Removed unneeded asset_dependencies
kalisp 436f51f
Replaced missed use_published
kalisp 02e0c85
Updates for Maya to show attr defs
kalisp 0a22384
Formatting to separate profile from actual presets
kalisp 1e71e44
Moved resolution of scene_path earlier
kalisp 69e9414
Removed unneeded plugin_info class variable
kalisp 18b1764
Removed unused import
kalisp d01479a
Refactored Blender submission
kalisp 2db8418
Refactored querying of plugin
kalisp 3bf017f
Implemented in Harmony
kalisp 91b9101
Implemented in Max
kalisp 567ed8c
Added comments and pools
kalisp 150bcd7
Refactored JobInfo for Unreal
kalisp 31b71b9
Refactored JobInfo for Houdini
kalisp ce2f93a
Reordered defaults
kalisp e39c116
Ruff fixes
kalisp 96afdfd
Fix missing import
kalisp 7c89b2c
Fix empty additional info
kalisp e0f1a29
Refactor Fusion submitter to be based on the AbstractSubmitDeadline p…
BigRoy af1e4f2
Improve `Delay Job` attribute definition (less long label, add placeh…
BigRoy f6c3974
Add some type hints to the code
BigRoy d8c44d9
Moved pools from separate plugin to collect_jobinfo
kalisp edff1c5
Merge branch 'feature/AY-6789_Render-instance-support-of-Frame-List' …
kalisp 18f5146
Merge pull request #56 from BigRoy/feature/AY-6789_Render-instance-su…
kalisp b5f178b
Added group to Publisher UI
kalisp 84783e8
Merge remote-tracking branch 'origin/feature/AY-6789_Render-instance-…
kalisp 124d715
Fix limit group placeholder
kalisp 42658bc
Fix empty plugin info
kalisp d202aaf
Implemented enum fields and querying for them
kalisp 13c80ec
Fix removing job_info
kalisp 2cb890a
Formatting added last empty line
kalisp f3db2b5
Fix removal of job_info
kalisp 7cf4c72
Fix use keyword argument
kalisp 193ea1c
Fix usage of keyword argument
kalisp 8526e5a
Fix sending of machine_list
kalisp 3b03400
Fix removal job_info
kalisp bd3010f
Fix do not trigger on not farm instances
kalisp 9fcc50a
Fix showing attributes for not farm instances
kalisp 3b81896
Fix typo
kalisp 3d6778c
Removed unnecessary class variables
kalisp 73b3400
Transformed Nuke to AbstractSubmitDeadline
kalisp 19639fb
Transformed CelAction to AbstractSubmitDeadline
kalisp 389fef8
Replaced attr with dataclass
kalisp 051d8e2
Refactored names of getters
kalisp 1461ffd
Removed unneeded comment
kalisp 2f58203
Refactor names to more precise
kalisp 7cdc12e
Reformatted docstrings
kalisp 1e39873
Added docstrings
kalisp 318fac0
Changed methods to classmethod
kalisp d6378a3
Changed methods to staticmethod
kalisp 3cbecec
Fix typo
kalisp 675a335
Refactored getter names
kalisp 0a42400
Refactored use of cls
kalisp 403d577
Refactored access to deadline info
kalisp ba7293d
Refactored utility methods for DL api to lib file
kalisp 86ddfb8
Fix typo
kalisp 6686f41
Removed obsolete fields for CelAction
kalisp 118ace2
Removed env_search_replace_values and env_allowed_keys
kalisp b8f3373
Removed hardoced chunk, uses from Profile
kalisp 3df6c16
Docstrings
kalisp 3ebe477
Added validator for priority
kalisp 37dcd72
Removed use_gpu from JobInfo
kalisp d2c0857
Fix pool
kalisp 8b7e43a
Fix pool
kalisp 39f359d
Merge
kalisp 877542f
Reordered imports
kalisp 286601f
Refactored logic
kalisp 6816382
Pass in project_settings
kalisp 397cf34
Use class variable
kalisp 781bab5
Refactored list fields
kalisp 5596190
Changed recalculating only on context change
kalisp 1068256
Fix removing job_info
kalisp 4b9d487
Fix pool collection
kalisp ce69056
Merge remote-tracking branch 'origin/feature/AY-6789_Render-instance-…
kalisp 46a90af
Merge branch 'develop' of https://github.com/ynput/ayon-deadline into…
kalisp c424311
Cleaned up plugin Settings
kalisp 112220e
Provided basic profile for CollectJobInfo
kalisp cd81da2
Added missed default artist overrides
kalisp 9732866
Fix wrong access to job_delay default value
kalisp 42148a9
Use list comprehension for pool enum
kalisp c9d1c4a
Use list comprehension for machines enum
kalisp d58ff4d
Use list comprehension
kalisp 005a5fb
Fix condition
kalisp deb8aa8
Fix copy to deepcopy
kalisp ba26549
Fix formatting
kalisp faa1cba
Use list comprehension for groups
kalisp ea9b2d6
Use list comprehension for limit groups
kalisp a307520
Use list comprehension for machine_limit defaults
kalisp 7e0ad18
Fix wrong assignment
kalisp df7a85e
Fix deepcopy from import
kalisp 5c4ebd0
Added deadline to instance families
kalisp c05ddc2
Make frames optional
kalisp d3cbe0b
Fix updates of job_info between jobs
kalisp 269b943
add missing import
MustafaJafar fa9327c
remove unused import
MustafaJafar 3aa671c
Fix propagation updated job_info
kalisp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably invalidate the cache after some time? There is helper
NestedCacheItem
class for thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother really. The query of this data is really quite slow most of the time - yet at the same time someone RARELY changes this on Deadline settings during production - and restarting the host integration I'd say is totally fine for those edge cases instead of slowness say every publish every five minutes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know about artists who have opened Nuke for a week. We should probably invalidate, cached values after some time.