-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish families to cache creators #149
Add publish families to cache creators #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did simple test on this, it is submitted to the farm successfully
Are we gonna wait for the merge of this PR #171 ? Or there should be something needed to be working on as I see this PR is still a draft?
This PR shouldn't add the intermediate publish family |
Actually @MustafaJafar - I think it is up to the creators to do so. This PR wasn't too far off, it should just be more dynamic. As soon as you toggle (on the creator) to submit it to the farm or not - then the relevant families should be added if set to farm. That way the attributes are still completely aligned with the instance's family. |
Is that achieved by implementing a callback that listens to the value change and assigns the family ? |
Correct - value change callback on the creator which adds/removes the farm related family based on the enum's state. One could approach it the opposite so that all this logic is in the Deadline plug-in to watch for creator attribute changes, however that means it's up to that plug-in to detect whether "farm is enabled" on the attribute which makes it harder to maintain over time if we want to expose the toggle in the creator a different way. Or like add a different additional toggle or whatever. Plus one would then need to duplicate that logic to ALL farm integrations (if there were more than Deadline) and hence it'd mean more maintenance, instead of all integrations just watching for some |
Changelog Description
This PR
farm
is enabledNote
This PR is mainly made for sharing code and show a use case for ynput/ayon-core#994
It should be used along ynput/ayon-deadline#49 and ynput/ayon-deadline#54
Here's what to expect when using the three PRs togther
Testing notes: