-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Farm cache publish support newer ayon-deadline versions #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Thank you.
Co-authored-by: Mustafa Jafar <[email protected]>
Actually - it was right. @MustafaJafar both create from context and this one being at |
So, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works.
But, do we need to make this plugin run at earlier time? the CollectJobInfo
has a late value pyblish.api.CollectorOrder + 0.420
I wonder if CollectFarmCacheFamily
plugin can be replaced by using the get_publish_families
method.
Sort of. But it shouldn't be there ALL the time, but only if
Honestly - I'd prefer to have it the EARLIEST so that it's entirely clear that is doesn't really depend on anything else. Whereas there may be more things relying on targeting But making this a changed callback since ynput/ayon-core#994 is merged could avoid this plug-in as described above. |
Merging this - because it fixes a bug. We can turn it into changed callback in separate PR. |
I forgot about that context plugin so it does fix a bug thank you. |
Changelog Description
Set the
publish.hou
family much earlier to avoid issues withayon-deadline
plug-ins that were ordered earlier than how we set it before this PR inayon-houdini
.Additional review information
Fixes #138
Testing notes: