-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load USD loaders with filepath from entity URI #26
Load USD loaders with filepath from entity URI #26
Conversation
2a1e32e
to
e584296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in not sure if we should ask the user to use uri at every step of the way tbh.
there are multiple Prs now where you have to enable Uri usage.
i dont say we should not allow for fine grain control if needed but i believe we should have one big button that says Use uri. and then the option to disable that for individual Systems.
It's not the user by the way, it's the studio "admin" defining that once in settings. So yes, it now provides granularity. We could do it differently by making all these enums that are three options:
And when "Use Default" is set it uses the big button. @iLLiCiTiT @Innders ideas? |
…gRoy/ayon-houdini into enhancement/usd_load_ayon_uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a slight glitch in URIs:
This URI works for me:
ayon+entity://USD_DEMO/assets/box?product=usdAsset&version=v002&representation=usd
and this is filled by this PR:
ayon+entity://USD_DEMO/assets/box&product=usdAsset&version=v002&representation=usd
The issue is here: ...box&product...
- it should use question mark.
This is handled by server call if I am not mistaken, so please disregard this if this is the case and we need to fix it there.
Correct - I fixed it this morning: ynput/ayon-backend#329 @antirotor can you test and approve if it works? Do note that there was also an issue with using |
Remove `os.path.normpath` completely. This should be completely fine, we were already _not_ doing that anyway on `update()` logic. So now `load()` actually matches the `update()` logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works now as expected
Changes the load behavior for the loaders that load to LOPs (e.g.
/stage
) to use AYON Entity URIs that can be resolved with the AYON USD Resolver.TODO
Additional context
Example URI after load is:
On the Load Asset LOP and Load Shot LOP there's now a toggle that defines whether it resolves as entity URI or not:
Testing notes
Build package and upload new addon.
Test with settings enabled/disabled: