Alembic Exports: Do not force a preroll starting at frame 0 #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixes Alembic Exports always defaulting to include a preroll run-up to the export from the
preRollStartFrame
, which defaulted to0
.Also fixes this warning always being logged:
Additional info
The "pre roll" was not included in the exported data - but it did mean that for EVERY alembic export we basically ended up stepping through the frame ranges from frame 0 up to the start frame of the Alembic to export.
I'd say this is actually quite an inconvenience for scenes that happen to also be heavy to step through time before the start frame because it'd heavily influence the time taken if you actually did not care about pre roll at all.
The bug was introduced around April/May via these PRs:
preRollStartFrame
argument this way.I believe it all came from a misconception about what the
preRoll
argument on theAbcExport
command was supposed to do. To explain that I'll just quote what I wrote as comment in the code for this PR:Testing notes:
How to debug
The easiest way to test this is to enable "Verbose" in settings:
ayon+settings://maya/publish/ExtractAlembic/verbose
You will then end up seeing the frame numbers printed by the Alembic Exporter - e.g. this:
Going all the way from frame zero.
What to test
Others that would be affected also calling
extract_alembic
and should now also NOT preroll from frame 0 but they did before this PR: