Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid being able to undo a part of containerisation #178

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Nov 14, 2024

Changelog Description

Containerise will now happen inside an undo chunk, disallowing to undo a part of the command.

Additional review information

Without this there is a bug if the user were to Load something and they would press UNDO a few times that they may have undo'ed a part of the containerisation. In particular, they may have undo'ed to JUST a state where the container is recognized but it lacks the representation attribute - meaning it will break anything that tries to get the container["representation"] value from the containers in the scene - e.g. loader, publishing from the scene (on collect input versions), etc.

This makes it so that if the user were to undo - it undoes the full creation of the container.

Technically we could ALSO add the same undo chunk decorator on all the maya loader plug-in methods to ensure they all operate in a single undo chunk.

Testing notes:

  1. Loading in Maya should work.
  2. Undoing should not undo 'parts of the container' like e.g. the creation of attributes on it but the full creation of it in one go.

TIP: To see containers in the outliner enable "Ignore hidden in outliner":
image

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Nov 14, 2024
@BigRoy BigRoy self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant