-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thumbnail extension to png #180
base: develop
Are you sure you want to change the base?
Conversation
…ually a png This fixes thumbnail uploading for AYON server 1.5.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspected thumbnail
representation details of the review
and it correctly uses PNG
as seen on the details pane below:
However not sure if that should also be used for thumbnail
captured via Publisher UI as my model have it and it says JPG
been used as repre type for model
product thumbnail
If its not related to this PR, just tell me and I will give approval asap...thx
Where do you see it mentioned to be |
@@ -74,7 +74,7 @@ def process(self, instance): | |||
|
|||
representation = { | |||
"name": "thumbnail", | |||
"ext": "jpg", | |||
"ext": "png", | |||
"files": thumbnail, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the thumbnail
variable holds .jpeg
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point!
Changelog Description
Change representation extension to
png
because the thumbnail is actually a pngAdditional review information
This fixes thumbnail uploading for AYON server 1.5.5
Testing notes: