Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnail extension to png #180

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Nov 14, 2024

Changelog Description

Change representation extension to png because the thumbnail is actually a png

Additional review information

This fixes thumbnail uploading for AYON server 1.5.5

Testing notes:

  1. Publishing review with AYON server 1.5.5+ should work

…ually a png

This fixes thumbnail uploading for AYON server 1.5.5
@BigRoy BigRoy added the type: bug Something isn't working label Nov 14, 2024
@BigRoy BigRoy self-assigned this Nov 14, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspected thumbnail representation details of the review and it correctly uses PNG as seen on the details pane below:

image

However not sure if that should also be used for thumbnail captured via Publisher UI as my model have it and it says JPG been used as repre type for model product thumbnail

If its not related to this PR, just tell me and I will give approval asap...thx

Screenshot 2024-11-14 155210

@BigRoy
Copy link
Contributor Author

BigRoy commented Nov 14, 2024

However not sure if that should also be used for thumbnail captured via Publisher UI as my model have it and it says JPG been used as repre type for model product thumbnail

Where do you see it mentioned to be JPG on the web?

@LiborBatek
Copy link
Member

However not sure if that should also be used for thumbnail captured via Publisher UI as my model have it and it says JPG been used as repre type for model product thumbnail

Where do you see it mentioned to be JPG on the web?

Its in the representation details on the thumbnail repre for the model product....that one comes from Publisher UI and was added by me before publishing... still JPG (but maybe it really is:) thats the reason I was asking if valid or not...

Screenshot 2024-11-14 173121

@@ -74,7 +74,7 @@ def process(self, instance):

representation = {
"name": "thumbnail",
"ext": "jpg",
"ext": "png",
"files": thumbnail,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the thumbnail variable holds .jpeg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants