Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable AYON_LOG_NO_COLORS in prelaunch hook #40

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Disable AYON_LOG_NO_COLORS in prelaunch hook #40

merged 1 commit into from
Nov 13, 2024

Conversation

johhnry
Copy link

@johhnry johhnry commented Nov 7, 2024 •
edited
Loading

Changelog Description

Fixes #24

  • Sets AYON_LOG_NO_COLORS to 1 in add_implementation_envs in NukeAddon class

Testing notes:

  1. Open Nuke from AYON
  2. The logs appear correctly

@BigRoy BigRoy added the type: bug Something isn't working label Nov 7, 2024
@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition and removed type: bug Something isn't working labels Nov 7, 2024
@johhnry johhnry force-pushed the ayon-log-no-colors-pre-hook branch 3 times, most recently from 1af1d75 to 7c23271 Compare November 7, 2024 11:40
BigRoy
BigRoy reviewed Nov 7, 2024
View reviewed changes
client/ayon_nuke/addon.py Outdated Show resolved Hide resolved
@BigRoy BigRoy added sponsored This is directly sponsored by a client or community member community Issues and PRs coming from the community members and removed sponsored This is directly sponsored by a client or community member labels Nov 7, 2024
moonyuet
moonyuet approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Nuke.

@jakubjezek001 jakubjezek001 merged commit 9b2cab0 into ynput:develop Nov 13, 2024
1 check passed
@johhnry johhnry deleted the ayon-log-no-colors-pre-hook branch November 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy left review comments

@moonyuet moonyuet moonyuet approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@robin-ynput robin-ynput Awaiting requested review from robin-ynput

Assignees
No one assigned
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding AYON_LOG_NO_COLORS into prelaunch hooks
4 participants
@johhnry @BigRoy @moonyuet @jakubjezek001