Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment injection to RoyalRender rendering jobs #1

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jul 16, 2024

Removed obsolete OP jobs, only pre job script necessary.

Direct copy from customer site, where it is used in production.

Removed obsolete OP jobs, only pre job script necessary.
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't currently test it because of the licensing issues, but code looks good and if it is already used in production without issues, I guess it can be safely merged. Just those two comments.

@kalisp kalisp requested a review from antirotor July 22, 2024 09:01
@64qam 64qam self-requested a review July 26, 2024 09:30
@kalisp kalisp merged commit 45a9d30 into develop Jul 26, 2024
1 check failed
@kalisp kalisp deleted the chore/AY-5674_Move-RoyalRender-env-injection-to-ayon-core branch July 26, 2024 10:04
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition bump minor labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants