Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made AYON connection env var optional #5

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Dec 17, 2024

Changelog Description

Previous implementation used AYON to control env necessary to connect to AYON server to generate environments for injection. This should be not necessary, as these env vars should be set on worker nodes only (and at least AYON_EXECUTABLE could be different), most likely with some studio automatization.

Additional review information

Old implementation depended on AYON_EXECUTABLE, AYON_SERVER_URL and AYON_API_KEY to be set on AYON side, most likely in Applications.

Testing notes:

  1. set required env vars on worker nodes
  2. publish without setting same environment vars in AYON, shouldnt fail

Previous implementation required AYON to control env necessary to connect to AYON server to generate environments for injection. This should be not necessary, as these env vars should be set on worker nodes only (and at least AYON_EXECUTABLE could be different).
@kalisp kalisp added the type: bug Something isn't working label Dec 17, 2024
@kalisp kalisp requested a review from antirotor December 17, 2024 16:24
@kalisp kalisp self-assigned this Dec 17, 2024
@MustafaJafar
Copy link

Can AYON_API_KEY be added to those file in rr_root?

@kalisp
Copy link
Member Author

kalisp commented Jan 6, 2025

AYON_API_KEY

Not sure I follow. You mean configuration file (in similar fashion as in Deadline)? Most likely (but even DL has option to override those with env vars set on specific workers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants