Skip to content

Commit

Permalink
Merge pull request #22 from ynput/enhancement/add-linting-validation
Browse files Browse the repository at this point in the history
Chore: Add linting action
  • Loading branch information
iLLiCiTiT authored Sep 26, 2024
2 parents df370fe + 77abe8f commit d586b9d
Show file tree
Hide file tree
Showing 4 changed files with 101 additions and 2 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/pr_linting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: 📇 Code Linting

on:
push:
branches: [ develop ]
pull_request:
branches: [ develop ]

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number}}
cancel-in-progress: true

permissions:
contents: read
pull-requests: write

jobs:
linting:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: chartboost/ruff-action@v1
75 changes: 75 additions & 0 deletions ruff.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# Exclude a variety of commonly ignored directories.
exclude = [
".bzr",
".direnv",
".eggs",
".git",
".git-rewrite",
".hg",
".ipynb_checkpoints",
".mypy_cache",
".nox",
".pants.d",
".pyenv",
".pytest_cache",
".pytype",
".ruff_cache",
".svn",
".tox",
".venv",
".vscode",
"__pypackages__",
"_build",
"buck-out",
"build",
"dist",
"node_modules",
"site-packages",
"venv",
"client/ayon_slack/python2_vendor/",
]

# Same as Black.
line-length = 79
indent-width = 4

[lint]
# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default.
# Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or
# McCabe complexity (`C901`) by default.
select = ["E4", "E7", "E9", "F", "W"]
ignore = []

# Allow fix for all enabled rules (when `--fix`) is provided.
fixable = ["ALL"]
unfixable = []

# Allow unused variables when underscore-prefixed.
dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"

[format]
# Like Black, use double quotes for strings.
quote-style = "double"

# Like Black, indent with spaces, rather than tabs.
indent-style = "space"

# Like Black, respect magic trailing commas.
skip-magic-trailing-comma = false

# Like Black, automatically detect the appropriate line ending.
line-ending = "auto"

# Enable auto-formatting of code examples in docstrings. Markdown,
# reStructuredText code/literal blocks and doctests are all supported.
#
# This is currently disabled by default, but it is planned for this
# to be opt-out in the future.
docstring-code-format = false

# Set the line length limit used when formatting code snippets in
# docstrings.
#
# This only has an effect when the `docstring-code-format` setting is
# enabled.
docstring-code-line-length = "dynamic"
2 changes: 1 addition & 1 deletion server/settings/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SlackSettings(BaseSettingsModel):

publish: SlackPublishPlugins = Field(
title="Publish plugins",
description="Fill combination of families, task names and hosts "
description="Fill combination of families, task names and hosts "
"when to send notification",
)

Expand Down
2 changes: 1 addition & 1 deletion server/settings/publish_plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class ChannelMessage(BaseSettingsModel):
upload_thumbnail: bool = Field(default=True, title="Upload thumbnail")
upload_review: bool = Field(default=True, title="Upload review")
message: str = Field('',
title="Message",
title="Message",
widget="textarea"
)

Expand Down

0 comments on commit d586b9d

Please sign in to comment.