Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a popup for the warning and make the addon start without qt #42

Closed
wants to merge 4 commits into from

Conversation

Lypsolon
Copy link
Collaborator

Changelog Description

this adds a HEADLESS MODE test and a TODO to improve the HEADLESS_MODE test as its currently very basic.
it also adds a QT popup to warn about not enabled plugin.

Additional info

Testing notes:

  1. upload addon
  2. dont activate / agree to the experimental tings
  3. start the launcher and see a popup

@Lypsolon Lypsolon marked this pull request as ready for review September 12, 2024 08:22
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about that change to HEADLESS_MODE as is in ayon-launcher. Also, we shouldn't touch submodule?

# flake8: noqa F401

# TODO ayon_api has a check for headless mode. we need to see if that system covers all fronts
HEADLESS_MODE = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it is used in ayon-launcher:

Suggested change
HEADLESS_MODE = True
HEADLESS_MODE_ENABLED = os.getenv("AYON_HEADLESS_MODE") == "1"

@Lypsolon Lypsolon closed this Sep 12, 2024
@Lypsolon Lypsolon deleted the make_startup_warning_a_popup branch September 12, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants