Fix execution condition and anatomy #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatomy isn't available on launch context to it needs to be specifically created. Also there was a bug about the condition when this hook should be executed.
BigRoy
reviewed
Sep 23, 2024
Co-authored-by: Roy Nieterau <[email protected]>
BigRoy
reviewed
Sep 23, 2024
BigRoy
reviewed
Sep 23, 2024
BigRoy
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Anatomy isn't available on launch context so it needs to be specifically created. Also there was a bug about the condition when this hook should be executed - it should only when there are pinning environments present on the job.
Testing notes:
Publish USD render job on farm - pinning should work if enabled.
Publish non-USD related job on farm - usd prelaunch hook should not be involved.