Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing LD_LIBRARY_PATH startup error if LD_LIBRARY_PATH has not been set before. #8

Closed

Conversation

Lypsolon
Copy link
Collaborator

@Lypsolon Lypsolon commented Jun 3, 2024

This PR intends to fix an issue that occurs if the LD_LIBRARY_PATH is not set before the pre-init hock gets triggered.

@Lypsolon Lypsolon requested a review from antirotor June 3, 2024 10:39
@ynbot
Copy link
Contributor

ynbot commented Jun 3, 2024

@Lypsolon
Copy link
Collaborator Author

Lypsolon commented Jun 3, 2024

@iLLiCiTiT
this is an error I'm getting when running your change.
AttributeERROR: 'ApplicationLaunchContext' object has no attribute 'get'

fix needed was to change line 140 to existing_ld_path = self.launch_context.env.get("LD_LIBRARY_PATH")

@Lypsolon
Copy link
Collaborator Author

Lypsolon commented Jun 4, 2024

closing in favour of #5

@Lypsolon Lypsolon closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants