Deletes unneeded instances to maybe save the server from being overrun by ghost scoops and cones if such a thing is not solved by garbage collection #22898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses :: instead of : from JohnFulpWillard
ToasterBiome
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
While helping me with my food cart PR, bug eating lizard pointed out that I was not deleting useless instances of items and that it could possibly overload the server with tons of instanced items. Welp, I copied said code from my ice cream vat code, some I've come back and fixed it so it deletes the instances once they're not needed anymore.
Why is this good for the game?
If it was possible to overload the server before due to my crappy code, it shouldn't be possible now :]
Testing
Everything seems to work fine with the qdel()'s and I'm not sure how I'd look to make sure the instances are actually being deleted.
Changelog
🆑
bugfix: Possibly fixes a bug that could cause the ice cream vat to overload the server with instanced cones and scoops
/:cl: