Created ContextInterface #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Finite/ContextInterface.php
Outdated
| * @return StateMachineInterface | ||
| */ | ||
| public function getStateMachine($object, $graph = 'default'); | ||
| } |
|
Seems ok, i'll merge after code review. |
|
Fixed. Thank you for your attention. |
|
Hi @yohang . I finished the code review. Do you have any other remarks? |
|
@luismulinari I'll have a look tomorrow, I was on vacation for a week. |
|
No problem @yohang . I can wait. |
|
Hi @yohang! Do you have an opinion about my PR? |
src/Finite/ContextInterface.php
Outdated
| use Finite\StateMachine\StateMachineInterface; | ||
|
|
||
| /** | ||
| * Interface that all class that have properties must implements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created ContextInterface to facilitate the "override" process.
I had a case when I needed to use "custom" Context because my "Finite twig extensions" should have other behavior. OK, I can extend the Context and use this, but in my specific case I don't need the Factory on constructor, for example.
I believe that with a Interface, this process will be more easy.