removing unneccessary state accessor initialization in costructor #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Humm, I merged a bit too fast. I'll have a look at the issue today. |
|
@yohang |
|
@yohang ? |
|
I dont think this repository is still being maintained. I am using my own fork with the PR for 4 years now |
|
Is this change already in the Or was this PR duplicated by #115 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue described in #117 . I have tried different initializations on my end and seems everything is fine.
@stephenjwinn Can you please confirm if this does indeed fix your issue?
@yohang Can you please confirm this does not break something I am not aware of? It should not since you need to bind an object to the state machine first where the state accessor is set to the default one