Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Signal proto3 optional support #239

Merged
merged 2 commits into from
May 3, 2022

Conversation

yoheimuta
Copy link
Owner

ref. #234

I checked the support locally as below.

(base) ❯ cat test.proto
syntax = "proto3";

package test;

message Test {
  optional string foo = 1;
}
(base) ❯ protoc --protolint_out=. test.proto
(base) ❯ cat test3.proto
syntax = "proto3";

package test;

message testTest {
  optional string foo = 1;
}
(base) ❯ protoc --protolint_out=. test3.proto
[test3.proto:5:1] Message name "testTest" must be UpperCamelCase like "TestTest"
--protolint_out: protoc-gen-protolint: Plugin failed with status code 1.

@yoheimuta yoheimuta merged commit bdd2093 into master May 3, 2022
@yoheimuta yoheimuta deleted the signal-proto3-optional-support branch May 3, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant