fix: Proxy Agent usage #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy variable will be used correctly. The HTTPS_PROXY / HTTP_PROXY will be used, if PROTOLINT_PROXY is not set. Evaluation takes place: if the remote url starts with https, HTTPS_PROXY will be used, otherwise HTTP_PROXY will be used. This interpretation is questionable, but makes sense in the first place. Closes yoheimuta#426
|
Hello carsencodes, |
|
Great. I just figured out, that this might be odd, if you don't want to use a proxy at all. So I would also add PROTOLINT_NO_PROXY ignoring all proxy settings tonight. |
Maybe useful in airgapped scenarios
Useful for airgapped scenarios
|
So, no proxy can be disabled in air-gapped scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy variable will be used correctly. The HTTPS_PROXY / HTTP_PROXY will be used, if PROTOLINT_PROXY is not set.
Evaluation takes place: if the remote url starts with https, HTTPS_PROXY will be used, otherwise HTTP_PROXY will be used.
This interpretation is questionable, but makes sense in the first place.
Closes #426