Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #58

Open
2 of 4 tasks
Jaylooker opened this issue Jul 12, 2018 · 0 comments
Open
2 of 4 tasks

Update dependencies #58

Jaylooker opened this issue Jul 12, 2018 · 0 comments
Labels

Comments

@Jaylooker
Copy link
Contributor

Jaylooker commented Jul 12, 2018

Dependencies haven't been update in 2 years.
Here are the current one's with security issues:

  • mocha (SEMVER warning with 1 critical, 1 high, 1 low , is dev-dependency)
  • superagent (SEMVER warning with 1 moderate, 1 low, is dependecy)
  • karma [dev] -> ... -> hoek (require manual update with 5 moderate, 1 low, is dev-dependency)
  • karma-browsify (check Update dependency #57, 1 issue, no SEMVER warning and doesn't require manual update, is dev-dependency)

Ran suggested npm install [email protected] (with browsify updated)
Got error log on test:

  Pixabayjs
    authenticate
      √ sets the client's key
    imageResultList
      √ returns a ResultList
      √ uses the image url
    videoResultList
      √ returns a ResultList
      √ uses the video url
ResultList
    initial request for page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    previous() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    next() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    previous() on page 2
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    second next() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    next() on page 2
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)


PhantomJS 2.1.1 (Windows 8 0.0.0): Executed 11 of 21 (6 FAILED) (0.143 secs / NaN secs)
TOTAL: 6 FAILED, 5 SUCCESS


1) "before all" hook
     ResultList initial request for page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

2) "before all" hook
     ResultList previous() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

3) "before all" hook
     ResultList next() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

4) "before all" hook
     ResultList previous() on page 2
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

5) "before all" hook
     ResultList second next() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

6) "before all" hook
     ResultList next() on page 2
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)


npm ERR! Test failed.  See above for more details.

Maybe superagent has deprecated code or something else.

Reverted back to base project (with browsify updated)
Ran suggested npm install --save-dev [email protected]
Test had no errors. Could possibly be added to #57.

The Karma[dev]-> ... ->hoek dependency may be a complex issue. I have not looked into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants