Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mocha dependency #59

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Update Mocha dependency #59

merged 1 commit into from
Jul 13, 2018

Conversation

Jaylooker
Copy link
Contributor

Is compatible and fixes major security issues from earlier verisons. 2.4.5->5.2.0 Changelog for reference and verison change details. Part of #58.

Is compatible and fixes major security issues. 2.4.5->5.2.0 [Changelog]( https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) for future reference.
@snitch
Copy link

snitch commented Jul 13, 2018

✨ No lint errors found. ✨

@stefanor
Copy link
Contributor

Thanks. It's a devDependency, so we don't need to cut a new release for it.

@stefanor stefanor merged commit 960d1cc into yola:master Jul 13, 2018
@Jaylooker
Copy link
Contributor Author

No problem, man. That makes sense for the release. I'm looking into Superagent and why it's throwing errors while testing using a new verison.

@Jaylooker
Copy link
Contributor Author

Jaylooker commented Jul 13, 2018

Seems like there's something wrong with the build through Travis CI? Having a build error for Node 8.

@stefanor
Copy link
Contributor

Retried it, it succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants