Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

french de-inflection #1626

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

french de-inflection #1626

wants to merge 4 commits into from

Conversation

SalwynnJP
Copy link

@SalwynnJP SalwynnJP commented Nov 28, 2024

This is a draft
Resolves #1572

If there is anything missing or any typo errors (although I think it's already quite complete), you can refer to the Bescherelle for verification.
https://ia801304.us.archive.org/8/items/BescherelleLaConjugaisonPourTous/bescherelle%20la%20conjugaison%20pour%20tous.pdf

@SalwynnJP SalwynnJP requested a review from a team as a code owner November 28, 2024 21:50
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Nov 28, 2024
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #1626 will not alter performance

Comparing SalwynnJP:master (6252d41) with master (51842b2)

Summary

✅ 3 untouched benchmarks

Signed-off-by: Salwynn <[email protected]>
@impucky
Copy link

impucky commented Dec 11, 2024

Commenting here since it was mentioned.
What's needed exactly, a look over of all the added de-inflection rules?
I'm a French native but I'm not sure I could spot anything that someone with a Bescherelle wouldn't. Happy to take a look though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[French]: French de-inflection logic
3 participants