Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing collection of removed elements from the root #140

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Oct 27, 2023

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the bug 🐞 Something isn't working label Oct 27, 2023
@7hong13 7hong13 requested review from hackerwins and skhugh October 27, 2023 04:58
@7hong13 7hong13 self-assigned this Oct 27, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I wonder why the CI is broken again. 🥲
Screenshot 2023-10-27 at 2 40 28 PM

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6782b5c) 78.22% compared to head (764d270) 78.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   78.22%   78.38%   +0.15%     
==========================================
  Files          63       63              
  Lines        3679     3715      +36     
  Branches      573      580       +7     
==========================================
+ Hits         2878     2912      +34     
+ Misses        503      498       -5     
- Partials      298      305       +7     
Files Coverage Δ
...c/main/kotlin/dev/yorkie/document/crdt/TextInfo.kt 88.23% <100.00%> (+2.02%) ⬆️
...lin/dev/yorkie/document/operation/EditOperation.kt 70.96% <100.00%> (ø)
...tlin/dev/yorkie/document/operation/SetOperation.kt 70.58% <100.00%> (+1.83%) ⬆️
...in/dev/yorkie/document/operation/StyleOperation.kt 76.92% <100.00%> (+5.49%) ⬆️
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 70.70% <0.00%> (+0.14%) ⬆️
...in/kotlin/dev/yorkie/document/crdt/RgaTreeSplit.kt 67.53% <0.00%> (-0.26%) ⬇️
...c/main/kotlin/dev/yorkie/document/json/JsonText.kt 72.72% <90.90%> (-0.61%) ⬇️
...c/main/kotlin/dev/yorkie/api/OperationConverter.kt 97.51% <50.00%> (-1.84%) ⬇️
...c/main/kotlin/dev/yorkie/document/crdt/CrdtText.kt 85.33% <76.47%> (-3.00%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 merged commit f701137 into main Oct 27, 2023
7 checks passed
@7hong13 7hong13 deleted the fix_gc branch October 27, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants