Fix missing removed elements collecting from root

Co-authored-by: Yourim Cha <[email protected]>

src/document/document.ts

@@ -977,6 +977,13 @@ export class Document<T, P extends Indexable = Indexable> {
     return this.root.getGarbageLen();
   }
 
+  /**
+   * `getGarbageLenFromClone` returns the length of elements should be purged from clone.
+   */
+  public getGarbageLenFromClone(): number {
+    return this.clone!.root.getGarbageLen();
+  }
+
   /**
    * `toJSON` returns the JSON encoding of this document.
    */

src/document/operation/set_operation.ts

@@ -68,8 +68,12 @@ export class SetOperation extends Operation {
     }
     const obj = parentObject as CRDTObject;
     const value = this.value.deepcopy();
-    obj.set(this.key, value);
+    const removed = obj.set(this.key, value);
     root.registerElement(value, obj);
+    if (removed) {
+      root.registerRemovedElement(removed);
+    }
+
     return {
       opInfos: [
         {

test/integration/gc_test.ts

@@ -586,4 +586,32 @@ describe('Garbage Collection', function () {
     await client1.deactivate();
     await client2.deactivate();
   });
+
+  it('Can collect removed elements from both root and clone', async function ({
+    task,
+  }) {
+    type TestDoc = { point: { x: number; y: number } };
+    const docKey = toDocKey(`${task.name}-${new Date().getTime()}`);
+    const doc1 = new yorkie.Document<TestDoc>(docKey);
+    const doc2 = new yorkie.Document<TestDoc>(docKey);
+
+    const client1 = new yorkie.Client(testRPCAddr);
+    const client2 = new yorkie.Client(testRPCAddr);
+
+    await client1.activate();
+    await client2.activate();
+
+    await client1.attach(doc1, { isRealtimeSync: false });
+    doc1.update((root) => {
+      root.point = { x: 0, y: 0 };
+    });
+    doc1.update((root) => {
+      root.point = { x: 1, y: 1 };
+    });
+    doc1.update((root) => {
+      root.point = { x: 2, y: 2 };
+    });
+    assert.equal(doc1.getGarbageLen(), 6);
+    assert.equal(doc1.getGarbageLenFromClone(), 6);
+  });
 });

test/unit/document/document_test.ts

@@ -1189,7 +1189,7 @@ describe.sequential('Document', function () {
       delete root.a;
     });
     assert.equal('{}', doc.toSortedJSON());
-    assert.equal(1, doc.getGarbageLen());
+    assert.equal(2, doc.getGarbageLen());
 
     doc.garbageCollect(MaxTimeTicket);
     assert.equal('{}', doc.toSortedJSON());