Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating simultaneous users' cursors movement example for SDK. #590

Merged
merged 37 commits into from
Aug 10, 2023

Conversation

YoonKiJin
Copy link
Contributor

@YoonKiJin YoonKiJin commented Jul 27, 2023

What this PR does / why we need it?

Creating simultaneous users' cursors movement example for SDK.

Tasks:

  • Implement basic functionality: 1. cursor movement display in local & multiple 2. cursor shapes display in local & multiple
  • Implement animation/drawing functionality(both local & multiple):
    • Pen cursor drawing animation
    • Heart/Thumbs cursors animation(visually aesthetic)

cursor

Any background context you want to provide?

Show another example of how Yorkie could be used.

What are the relevant tickets?

Address yorkie-team/yorkie-team.github.io#12

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #590 (1b2caa5) into v0.4.5-example (a36c00f) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 1b2caa5 differs from pull request most recent head d928b71. Consider uploading reports for the commit d928b71 to get more accurate results

@@                Coverage Diff                 @@
##           v0.4.5-example     #590      +/-   ##
==================================================
+ Coverage           87.47%   87.52%   +0.05%     
==================================================
  Files                  81       81              
  Lines                7937     7953      +16     
  Branches              817      816       -1     
==================================================
+ Hits                 6943     6961      +18     
+ Misses                680      679       -1     
+ Partials              314      313       -1     

see 3 files with indirect coverage changes

@YoonKiJin YoonKiJin marked this pull request as ready for review August 3, 2023 05:14
@hackerwins
Copy link
Member

@YoonKiJin Some commits were pushed after changing the status from draft to ready in this PR. Is this PR ready to review?

@YoonKiJin YoonKiJin marked this pull request as draft August 7, 2023 01:25
@YoonKiJin
Copy link
Contributor Author

I reconverted to a draft. I'll make some additional changes before resubmitting for a review.

@hackerwins hackerwins changed the base branch from main to v0.4.5-example August 9, 2023 11:17
@hackerwins
Copy link
Member

I changed the base of this PR from main to v0.4.5-example, because server v0.4.5 is not deployed yet to https://api.yorkie.dev.

@YoonKiJin If you are ready to review this PR. please let us know.

@YoonKiJin YoonKiJin marked this pull request as ready for review August 10, 2023 07:17
Copy link
Contributor

@chacha912 chacha912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
It would be great to improve the remote pen animation in the next step: #612

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants