-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce mark operation to Text.setStyle #647
Draft
MoonGyu1
wants to merge
25
commits into
main
Choose a base branch
from
peritext
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main yorkie-team/yorkie-js-sdk#647 +/- ##
==========================================
- Coverage 71.38% 67.48% -3.91%
==========================================
Files 58 58
Lines 8734 9155 +421
Branches 784 829 +45
==========================================
- Hits 6235 6178 -57
- Misses 2241 2700 +459
- Partials 258 277 +19
☔ View full report in Codecov by Sentry. |
9 tasks
hackerwins
force-pushed
the
main
branch
2 times, most recently
from
October 20, 2023 07:46
a9325d6
to
7baa69f
Compare
hackerwins
force-pushed
the
main
branch
6 times, most recently
from
November 25, 2023 14:15
5d46577
to
0e34144
Compare
2 tasks
hackerwins
force-pushed
the
main
branch
2 times, most recently
from
May 10, 2024 00:21
7dba6db
to
f765d1c
Compare
hackerwins
force-pushed
the
main
branch
5 times, most recently
from
August 16, 2024 04:24
ad3b86a
to
2f1cd8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Currently, the
Text.setStyle
logic sometimes doesn't adequately preserve user intent when formatting text concurrently. The Peritext CRDT algorithm classifies these user intentions into 9 different cases for rich-text concurrent editing. This PR introduces the mark operation of the Peritext algorithm toText
and enables the reflection of user intent in concurrent editing scenarios.bold
mark type as part of feasibility testing.Any background context you want to provide?
Currently, it is in the process of being implemented for some types, and in the future, it can be extended to include additional types. Ultimately, we can move in the direction of providing users with a customizable interface.
What are the relevant tickets?
Address yorkie-team/yorkie#672
Checklist