-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement undo/redo example with tldraw #695
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 58 58
Lines 8787 8787
Branches 800 800
=======================================
Hits 6067 6067
Misses 2459 2459
Partials 261 261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, file newline here.
@devleejb |
@krapie |
The current Undo/Redo implementation in the JS SDK is designed for objects, but it malfunctions when the garbage collection(GC) is triggered. Therefore, in the current Undo/Redo test code, the GC functionality is disabled to run the tests: yorkie-js-sdk/test/integration/object_test.ts Lines 854 to 855 in 5ef1e8f
In the future, there are plans to handle the removal of objects targeted by the GC when they are no longer referenced by the undo/redo stack. For more details, please refer to the following issue: I think it will take some time. |
7dba6db
to
f765d1c
Compare
ad3b86a
to
2f1cd8b
Compare
What this PR does / why we need it?
This pull request adds undo/redo functionality to the Tldraw whiteboard example code.
Any background context you want to provide?
public/index.html
code for modifications.What are the relevant tickets?
Fixes #
Checklist