Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset online clients when stream is disconnected #796

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Apr 30, 2024

What this PR does / why we need it?

When the stream is disconnected, online-clients' information should be cleared and no longer accessible.

reset-unwatch.mov

Any background context you want to provide?

Before, the initialized event only occurred when first attaching to the document, indicating who was using it. Now, it also occurs if the watch stream is disconnected and clients have reset.

What are the relevant tickets?

Address #791

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (cd33ea7) to head (5586540).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
+ Coverage   80.24%   80.50%   +0.26%     
==========================================
  Files          59       59              
  Lines        4439     4448       +9     
  Branches      898      901       +3     
==========================================
+ Hits         3562     3581      +19     
+ Misses        613      605       -8     
+ Partials      264      262       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 589dd8f into main Apr 30, 2024
2 checks passed
@hackerwins hackerwins deleted the reset-online-clients branch April 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants