Skip to content

Commit

Permalink
Fix a bug introduced in 6e96049.
Browse files Browse the repository at this point in the history
`flacenc-exp` binary is no longer produced by cargo, but reporter script
was still using it to produce the performance report.
  • Loading branch information
yotarok committed Sep 21, 2023
1 parent 4de1a88 commit ce56898
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
6 changes: 0 additions & 6 deletions flacenc-bin/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,6 @@ struct Args {
#[allow(clippy::expect_used)]
fn write_stream<F: Write>(stream: &Stream, file: &mut F) {
eprintln!("{} bits to be written", stream.count_bits());
// let mut bv: BitVec<u8, Msb0> = BitVec::with_capacity(stream.count_bits());
// stream.write(&mut bv).expect("Bitstream formatting failed.");
// let mut writer = BufWriter::new(file);
// writer
// .write_all(bv.as_raw_slice())
// .expect("File write failed.");
let mut bv = flacenc::bitsink::ByteVec::new();
stream.write(&mut bv).expect("Bitstream formatting failed.");
let mut writer = BufWriter::new(file);
Expand Down
14 changes: 7 additions & 7 deletions report/report.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ Sources used: wikimedia.i_love_you_california, wikimedia.winter_kiss, wikimedia.

### Average compression speed (inverse RTF)
- Reference
- opt8lax: 257.7849467896516
- opt8: 251.1527880915968
- opt5: 501.03630516078925
- opt8lax: 257.9766459270744
- opt8: 256.2010819290685
- opt5: 477.0431609974724

- Ours
- default: 52.7637956617831
- dmse: 52.35116821103436
- bsbs: 52.11728073283382
- mae: 52.33861337278744
- default: 49.95345620740272
- dmse: 49.862356799167635
- bsbs: 49.19340838451352
- mae: 49.70608853734756


4 changes: 1 addition & 3 deletions testtool/reporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,7 @@ def main():
test_run_results = run_encoder(
inputs,
testenc_out_root,
str(
project_root / "flacenc-bin" / "target" / "release" / "flacenc-exp"
),
str(project_root / "flacenc-bin" / "target" / "release" / "flacenc"),
TEST_ENCODER_OPTS,
)

Expand Down

0 comments on commit ce56898

Please sign in to comment.