Fixed encoder error when encoding WAV 8/24-bit input. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By specification, WAV file stores numbers in unsigned format with some offset values added when bits-per-sample is less than (or equal to) 8. For 24-bit, some parser functions had assert-statement to verify `bits_per_sample <= MAX_BITS_PER_SAMPLE` that is 24. However, this assumption is wrong for `SubFrames` of side-channels. For fixing this bug, this commits does: 1. perform u8+offset to i8 in `HoundSource`. 2. MD5 check is introduced to "flacenc-bin" 3. integration test now can output intermediate file to a specified directory for debugging. 4. a test added for `arrayutils::le_bytes_to_i32s` (found out not to be a bug of this function, though) 5. changed assert-statement to check `bits_per_sample <= MAX_BITS_PER_SAMPLE + 1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specification, WAV file stores numbers in unsigned format with some offset values added when bits-per-sample is less than (or equal to) 8.
For 24-bit, some parser functions had assert-statement to verify
bits_per_sample <= MAX_BITS_PER_SAMPLEthat is 24. However, this assumption is wrong forSubFramesof side-channels.For fixing this bug, this commits does:
HoundSource.arrayutils::le_bytes_to_i32s(found out not to be a bug of this function, though)bits_per_sample <= MAX_BITS_PER_SAMPLE + 1