chore: some code cleanups

you-apps · Oct 28, 2024 · 4dc1aad · 4dc1aad
1 parent b8b5b90
commit 4dc1aad
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/app/src/main/java/com/bnyro/clock/navigation/NavRoutes.kt b/app/src/main/java/com/bnyro/clock/navigation/NavRoutes.kt
@@ -6,13 +6,13 @@ import androidx.navigation.navArgument
 sealed class NavRoutes(
     val route: String
 ) {
-    object Home : NavRoutes("home")
-    object Settings : NavRoutes("settings")
-    object AlarmPicker : NavRoutes("alarmPicker") {
-        const val alarmId = "alarmId"
-        val routeWithArgs = "$route/{$alarmId}"
-        val args = listOf(navArgument(alarmId) { NavType.LongType })
+    data object Home : NavRoutes("home")
+    data object Settings : NavRoutes("settings")
+    data object AlarmPicker : NavRoutes("alarmPicker") {
+        const val ALARM_ID = "alarmId"
+        val routeWithArgs = "$route/{$ALARM_ID}"
+        val args = listOf(navArgument(ALARM_ID) { NavType.LongType })
     }
 
-    object Permissions : NavRoutes("permissions")
+    data object Permissions : NavRoutes("permissions")
 }
diff --git a/app/src/main/java/com/bnyro/clock/presentation/screens/alarm/components/TimePickerDialog.kt b/app/src/main/java/com/bnyro/clock/presentation/screens/alarm/components/TimePickerDialog.kt
@@ -44,7 +44,7 @@ fun TimePickerDialog(
         initialHour = initialTime?.hours ?: 0,
         initialMinute = initialTime?.minutes ?: 0
     )
-    var keyboardPickerState by remember {
+    val keyboardPickerState by remember {
         mutableStateOf(KeyboardPickerState())
     }
 

diff --git a/app/src/main/java/com/bnyro/clock/presentation/screens/alarmpicker/model/AlarmPickerModel.kt b/app/src/main/java/com/bnyro/clock/presentation/screens/alarmpicker/model/AlarmPickerModel.kt
@@ -20,7 +20,7 @@ import kotlin.time.Duration.Companion.milliseconds
 
 class AlarmPickerModel(application: Application, savedStateHandle: SavedStateHandle) :
     AndroidViewModel(application) {
-    private val id: String? = savedStateHandle[NavRoutes.AlarmPicker.alarmId]
+    private val id: String? = savedStateHandle[NavRoutes.AlarmPicker.ALARM_ID]
 
     private val alarmRepository = (application as App).container.alarmRepository
     private val createUpdateDeleteAlarmUseCase =
@@ -30,10 +30,10 @@ class AlarmPickerModel(application: Application, savedStateHandle: SavedStateHan
 
     init {
         val alarmId = id?.toLong() ?: 0L
-        if (alarmId == 0L) {
-            alarm = Alarm(time = 0)
+        alarm = if (alarmId == 0L) {
+            Alarm(time = 0)
         } else {
-            alarm = runBlocking(Dispatchers.IO) {
+            runBlocking(Dispatchers.IO) {
                 alarmRepository.getAlarmById(alarmId)
             }
         }