타입 수정 및 네이밍 분리 (userId, hashedId) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JjungminLee
approved these changes
Feb 6, 2024
JjungminLee
reviewed
Feb 6, 2024
| path?: string; | ||
| tags?: string[]; | ||
| } | ||
|
|
||
| // LogPayloadParams: 사용처에서 넣어주는 값 | ||
| export interface LogPayloadParams { |
There was a problem hiding this comment.
사용처에서 넣어주는 값으로 로그 모델 통일하는거 좋습니닷!
| const screen = ({ serviceName, name }: LogPayloadParams) => { | ||
| //사용자에서 path,name,message를 넣어줌 | ||
| const loggerType: LoggerType = { | ||
| const screen = ({ userId, serviceName, name }: LogPayloadParams) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
사용처에서 event 내부 값만 보내주는 것이 아닌 userId도 같이 보내주므로 기존에 존재하던 LoggerType(event 내부 값만 취급)을 제거하였습니다.
LogPayloadParams(사용처에서 넣어주는 값, 타입) 내부 userId 타입을 number -> string
LogType(최종 Log 형태)의 기존 userId -> hashedId 네이밍 변경 및 타입 number -> string
setLocalStorage 로직을 삭제하였습니다.
주석도 저번에 얘기 나눈대로 살짝 수정했습니다~!
demo app에도 수정 사항 반영해뒀습니다.
resolved [FEAT] userId, hashedId 네이밍 분리 #18
3️⃣ 추후 작업
createHashedId 함수 구현
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?