feat: 백엔드 로그 전달 #30
Merged
feat: 백엔드 로그 전달 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanna922
reviewed
Feb 23, 2024
src/Logger.ts
Outdated
| @@ -95,6 +95,7 @@ window.addEventListener('unload', async (event) => { | |||
|
|
|||
| const logList: any[] = JSON.parse(localStorage.getItem('yls-web') as string) || []; | |||
|
|
|||
| // const res = await postLog(logList); | |||
| const res = await postLog(logList); | |||
| console.log(res); | |||
src/apis/postLog.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import customedAxios from './customedAxios'; | |||
|
|
|||
| export const postLog = async () => { | |||
| const res = await customedAxios.put(''); | |||
| export const postLog = async (data: any) => { | |||
There was a problem hiding this comment.
models 폴더 생성 후 data 타입 명시해줄 수 있을까용? types 내부와 동일하다면 해당 타입으로 명시해도 될 것 같아요!
호옥시 Logger.ts의 96번 라인의 any도 변경 가능할까욥??
There was a problem hiding this comment.
types의 최종 로그 타입과 동일해서 바꿔두었습니다~!
유저가 행동하다가 이탈할수도 있어서 우선은 맘 편하게 /log/list로 해보려구요~! |
Hanna922
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
2️⃣ 알아두시면 좋아요!
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?