refactor: 사용처에서 path 보내주는 로직 수정 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JjungminLee
reviewed
Feb 23, 2024
| @@ -10,10 +10,16 @@ interface Props { | |||
| export const LogClick = ({ children, params }: Props) => { | |||
| const logger = useYLSLogger(); | |||
| const child = Children.only(children); | |||
| let path = params.path; | |||
|
|
|||
| if (!params.path) path = window.location.pathname; | |||
There was a problem hiding this comment.
이게 이전의 router.pathname을 대신하는거죠?!
There was a problem hiding this comment.
네네 사용처에서 매번 router.pathname을 해줘야 하는 걸 YLS에서 처리하도록 만들었어용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
작업 해놓고 push 하는 걸 까먹고 있었네요 ㅠㅡㅠ
기존 코드에 영향을 미치는 변경사항
사용처에서 매번 path를 넣어주지 않아도 되게끔 리팩토링 했습니다.
serviceName도 넣어주지 않게끔 변경하고 싶었는데, Context를 사용해야 할 것 같습니다.
그래서 살짝 보류 합니다..~!
3️⃣ 추후 작업
version 필드 추가
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?