feat: setting react package and create useInterval #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 환경 변수 관련 이슈 추후 해결할 예정
- 패키지 단위 테스트 적용, package.json 설정
# Conflicts: # package.json # packages/react/tsconfig.json # pnpm-lock.yaml
Hanna922
approved these changes
Jun 3, 2024
Hanna922
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
react package를 추가했고 기본적인 설정 파일들을 생성했습니다.
useInterval 훅과 그에 대한 ko.md test.ts 파일을 추가했습니다.
기존 코드에 영향을 미치는 변경사항
main을 당겨오는 과정에서 conflict가 발생했는데 아마 react package에 관련된 명령어를 root에 포함시키는 과정에서 발생한 것 같습니다.
버그 픽스
2️⃣ 알아두시면 좋아요!
훅을 테스트하기 위해서 @testing-library/react devDependency를 추가했습니다.
3️⃣ 추후 작업
useFunnel, useSuspensedQuery 등 다양한 훅을 추가합니다.
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?