-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@yourssu/eslint-config, @yourssu/prettier-config): create eslint, prettier packages #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"prettier-config": "pnpm --filter @yourssu/prettier-config",
- module.exports 에서 빨간 줄 발생하고 있어서 root package.json type 제거
…ssu/Yrano into feat/#4-lint-config-package
Hanna922
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root 경로 .prettierrc.json 제거해주세요!
Hanna922
reviewed
Jun 15, 2024
ac8f39f
to
6d041f4
Compare
Hanna922
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
prettier-config
패키지 추가,index.js
에 prettier 옵션 추가eslint-config/index.js
추가,eslint-config/react.js
추가 (리액트만을 위한 설정 분리)기존 코드에 영향을 미치는 변경사항
lint-config
->eslint-config
package.json
에서 eslint & prettier 관련 의존성 제거2️⃣ 알아두시면 좋아요!
prettier 관련 eslint 도입 방법 변경
before :
after :
aria 관련 설정 값 어떻게 생각하시나요..?!3️⃣ 추후 작업
4️⃣ 체크리스트 (Checklist)
main
브랜치의 최신 코드를pull
받았나요?