Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@yourssu/eslint-config, @yourssu/prettier-config): create eslint, prettier packages #27

Merged
merged 42 commits into from
Jun 15, 2024

Conversation

intersoom
Copy link
Member

1️⃣ 어떤 작업을 했나요? (Summary)

기존 코드에 영향을 미치지 않는 변경사항

  • prettier-config 패키지 추가, index.js에 prettier 옵션 추가
  • eslint-config/index.js 추가, eslint-config/react.js 추가 (리액트만을 위한 설정 분리)
  • example 테스트용 패키지 생성

기존 코드에 영향을 미치는 변경사항

  • 네이밍 변경 : lint-config -> eslint-config
  • root의 package.json에서 eslint & prettier 관련 의존성 제거

2️⃣ 알아두시면 좋아요!

  • prettier 관련 eslint 도입 방법 변경

    • 기존 숨실 코드에는 plugin / extend 각각 import 했지만, 공식 문서에서 한 번에 import하는 방식이 존재해서 해당 방식으로 변경하였습니다!

    before :

    extends: [
      'prettier',
    ],
    plugins: ['prettier']
    

    after :

    extends: [
      'eslint:recommended',
    ],
    
  • aria 관련 설정 값 어떻게 생각하시나요..?!

3️⃣ 추후 작업

  • 모각코 시간에 lint, prettier 설정 관련 논의 후 반영

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

Copy link
Member

@Hanna922 Hanna922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root 경로 .prettierrc.json 제거해주세요!

@intersoom intersoom requested a review from Hanna922 June 14, 2024 07:27
@Hanna922 Hanna922 force-pushed the feat/#4-lint-config-package branch from ac8f39f to 6d041f4 Compare June 15, 2024 12:07
@Hanna922 Hanna922 merged commit b61ae7f into main Jun 15, 2024
@Hanna922 Hanna922 deleted the feat/#4-lint-config-package branch June 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: setting eslint-config, prettier-config package
2 participants