Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add utils package #7

Merged
merged 5 commits into from
May 29, 2024
Merged

feat: add utils package #7

merged 5 commits into from
May 29, 2024

Conversation

owl1753
Copy link
Collaborator

@owl1753 owl1753 commented May 29, 2024 •
edited
Loading

1️⃣ 어떤 작업을 했나요? (Summary)

2️⃣ 알아두시면 좋아요!

  • ko.md를 제 맘대로 작성했는데... 이렇게 작성하는게 맞나요?

3️⃣ 추후 작업

  • utils 패킺에 다양한 유틸 함수를 추가하거나, 유용한 훅들을 패키지로 구축합니다.

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

@owl1753 owl1753 self-assigned this May 29, 2024
@owl1753 owl1753 added feat New feature or request utils @yourssu/utils labels May 29, 2024
@Hanna922 Hanna922 requested review from intersoom and Hanna922 May 29, 2024 02:58
intersoom
intersoom approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@intersoom intersoom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 조아용 저는 ko.md 파일 깔꼬롬 해서 좋은 것 같아요 🤔

Hanna922
Hanna922 reviewed May 29, 2024
View reviewed changes
Copy link
Member

@Hanna922 Hanna922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요옹 #6 머지 후에 test.ts도 작성하면 좋을 것 같아요

@owl1753 owl1753 requested a review from nijuy as a code owner May 29, 2024 13:27
@owl1753 owl1753 requested review from Hanna922 and intersoom May 29, 2024 13:28
Hanna922
Hanna922 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Hanna922 Hanna922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드도 다양하고 함수에 주석 달아주신 것도 좋네요

@owl1753 owl1753 merged commit 6171a65 into main May 29, 2024
owl1753 added a commit that referenced this pull request May 29, 2024
@owl1753
Revert "feat: add utils package (#7)"
09a8fe6 
This reverts commit 6171a65.
@owl1753 owl1753 deleted the feat/#3-utils-package branch May 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanna922 Hanna922 Hanna922 approved these changes

@nijuy nijuy Awaiting requested review from nijuy nijuy is a code owner

@intersoom intersoom Awaiting requested review from intersoom intersoom is a code owner

Assignees

@owl1753 owl1753

Labels
feat New feature or request utils @yourssu/utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: utils 패키지 구축
3 participants
@owl1753 @intersoom @Hanna922