Skip to content

Commit

Permalink
mk: support Node 23.x
Browse files Browse the repository at this point in the history
  • Loading branch information
yoursunny committed Nov 24, 2024
1 parent b63f7a6 commit aa3e1f9
Show file tree
Hide file tree
Showing 22 changed files with 31 additions and 33 deletions.
14 changes: 6 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
key: build-${{ hashFiles('**/package.json') }}
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
- run: corepack pnpm install
env:
PUPPETEER_SKIP_DOWNLOAD: true
Expand All @@ -26,7 +26,7 @@ jobs:
unittest:
strategy:
matrix:
node: [20, 22]
node: [20, 22, 23]
fail-fast: false
runs-on: ubuntu-22.04
steps:
Expand All @@ -52,15 +52,13 @@ jobs:
env:
PUPPETEER_SKIP_DOWNLOAD: true
- run: corepack pnpm test
if: ${{ matrix.node == 22 }}
if: ${{ matrix.node != 22 }}
- run: corepack pnpm cover
env:
NODE_OPTIONS: --experimental-websocket
if: ${{ matrix.node == 20 }}
if: ${{ matrix.node == 22 }}
- uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
if: ${{ matrix.node == 20 }}
if: ${{ matrix.node == 22 }}
continue-on-error: true
timeout-minutes: 30
integ:
Expand All @@ -77,7 +75,7 @@ jobs:
key: integ-${{ hashFiles('**/package.json') }}
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
- name: Install dependencies
run: |
echo "deb [arch=amd64 trusted=yes] https://nfd-nightly-apt.ndn.today/ubuntu jammy main" \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

Supported platforms include:

* Node.js: 20.x and 22.x, on Windows and Linux.
* Node.js: 20.x and 22.x and 23.x, on Windows and Linux.
* Generally, I support *Active LTS* and *Current* versions.
* Bundlers: webpack 5.
* Firefox: latest version on Windows and Mac.
Expand Down
4 changes: 2 additions & 2 deletions integ/browser-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
"devDependencies": {
"@nodelib/fs.walk": "^2.0.0",
"@types/webpack": "^5.28.5",
"@zenfs/core": "^1.3.5",
"@zenfs/core": "^1.3.6",
"@zenfs/dom": "^1.0.6",
"fork-ts-checker-webpack-plugin": "^9.0.2",
"html-webpack-plugin": "^5.6.3",
"puppeteer": "^23.9.0",
"ts-loader": "^9.5.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"webpack": "^5.96.1",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^5.1.0"
Expand Down
2 changes: 1 addition & 1 deletion mk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"js-yaml": "^4.1.0",
"readlink": "^3.0.0",
"split2": "^4.2.0",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"packageManager": "[email protected]+sha512.6e2baf77d06b9362294152c851c4f278ede37ab1eba3a55fda317a4a17b209f4dbb973fb250a77abc463a341fcb1f17f17cfa24091c4eb319cda0d9b84278387",
"devDependencies": {
"@types/node": "^20.17.6",
"@types/node": "^20.17.7",
"@types/wtfnode": "^0.7.3",
"@typescript/lib-dom": "npm:@types/[email protected]",
"@vitest/coverage-v8": "^2.1.5",
Expand All @@ -27,7 +27,7 @@
"vitest": "^2.1.5"
},
"engines": {
"node": "^20.12.0 || ^22.0.0"
"node": "^20.18.0 || ^22.11.0 || ^23.0.0"
},
"pnpm": {
"peerDependencyRules": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/autoconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@
"@types/default-gateway": "^7.2.2",
"@types/koa": "^2.15.0",
"koa": "^2.15.3",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
}
}
2 changes: 1 addition & 1 deletion pkg/fileserver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@ndn/segmented-object": "workspace:*",
"@ndn/tlv": "workspace:*",
"@ndn/util": "workspace:*",
"@zenfs/core": "^1.3.5",
"@zenfs/core": "^1.3.6",
"mnemonist": "^0.39.8",
"obliterator": "^2.0.4",
"streaming-iterables": "^8.0.1",
Expand Down
2 changes: 1 addition & 1 deletion pkg/keychain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"idb-keyval": "^6.2.1",
"mnemonist": "^0.39.8",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"wait-your-turn": "^1.0.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/l3face/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"retry": "^0.13.1",
"streaming-iterables": "^8.0.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1"
}
}
2 changes: 1 addition & 1 deletion pkg/nac/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@yoursunny/asn1": "0.0.20200718",
"mnemonist": "^0.39.8",
"tslib": "^2.8.1",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
},
"devDependencies": {
"@ndn/l3face": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion pkg/ndncert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"nodemailer": "^6.9.16",
"p-timeout": "^6.1.3",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/nfdmgmt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"devDependencies": {
"@ndn/l3face": "workspace:*",
"@ndn/node-transport": "workspace:*",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1"
}
}
2 changes: 1 addition & 1 deletion pkg/node-transport/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"event-iterator": "^2.0.0",
"p-event": "^6.0.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"url-format-lax": "^2.0.0",
"url-parse-lax": "^5.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/packet/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"buffer-compare": "^1.1.1",
"mnemonist": "^0.39.8",
"tslib": "^2.8.1",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
},
"devDependencies": {
"@types/buffer-compare": "^0.0.33"
Expand Down
2 changes: 1 addition & 1 deletion pkg/pyrepo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"p-defer": "^4.0.1",
"streaming-iterables": "^8.0.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/repo-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
"@ndn/node-transport": "workspace:*",
"@ndn/segmented-object": "workspace:*",
"stream-mock": "^2.0.5",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
}
}
2 changes: 1 addition & 1 deletion pkg/repo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"memory-level": "^2.0.0",
"streaming-iterables": "^8.0.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1",
"wait-your-turn": "^1.0.1"
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/segmented-object/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@ndn/naming-convention2": "workspace:*",
"@ndn/packet": "workspace:*",
"@ndn/util": "workspace:*",
"@zenfs/core": "^1.3.5",
"@zenfs/core": "^1.3.6",
"it-keepalive": "^1.2.0",
"mnemonist": "^0.39.8",
"obliterator": "^2.0.4",
Expand All @@ -45,6 +45,6 @@
"@ndn/l3face": "workspace:*",
"@ndn/repo-api": "workspace:*",
"stream-mock": "^2.0.5",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
}
}
2 changes: 1 addition & 1 deletion pkg/svs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@ndn/util": "workspace:*",
"streaming-iterables": "^8.0.1",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"typescript-event-target": "^1.1.1",
"wait-your-turn": "^1.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/tlv/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
"@ndn/util": "workspace:*",
"mnemonist": "^0.39.8",
"tslib": "^2.8.1",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
}
}
2 changes: 1 addition & 1 deletion pkg/trust-schema/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"mnemonist": "^0.39.8",
"obliterator": "^2.0.4",
"tslib": "^2.8.1",
"type-fest": "^4.27.0"
"type-fest": "^4.28.0"
},
"devDependencies": {
"@ndn/l3face": "workspace:^",
Expand Down
4 changes: 2 additions & 2 deletions pkg/util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"streaming-iterables": "^8.0.1",
"tiny-invariant": "^1.3.3",
"tslib": "^2.8.1",
"type-fest": "^4.27.0",
"type-fest": "^4.28.0",
"wait-your-turn": "^1.0.1"
},
"devDependencies": {
Expand All @@ -43,6 +43,6 @@
"write": "^2.0.0"
},
"engines": {
"node": "^20.12.0 || ^22.0.0"
"node": "^20.18.0 || ^22.11.0 || ^23.0.0"
}
}

0 comments on commit aa3e1f9

Please sign in to comment.