Skip to content

Commit

Permalink
Set Github Actions build job timeouts
Browse files Browse the repository at this point in the history
Adds default timeouts for build jobs, to prevent hang bugs from
consuming all resources.

b/343787224
  • Loading branch information
kaidokert committed May 31, 2024
1 parent 04a009e commit 001cb0e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ jobs:
github.event.label.name == 'runtest' ||
github.event.label.name == 'on_device'
)
timeout-minutes: 10
steps:
- id: checkout
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -148,6 +149,7 @@ jobs:
runs-on: [self-hosted, linux-runner]
permissions:
packages: write
timeout-minutes: 30
steps:
- name: Checkout files
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -184,6 +186,7 @@ jobs:
permissions:
packages: write
runs-on: [self-hosted, linux-runner]
timeout-minutes: 30
steps:
- name: Checkout files
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -231,6 +234,7 @@ jobs:
# However, dind container ends up having / folder mounted on overlay
# filesystem, whereas /__w which contains Cobalt source code is on tmpfs.
TMPDIR: /__w/_temp
timeout-minutes: 90
steps:
- name: Checkout
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -335,6 +339,7 @@ jobs:
COBALT_EVERGREEN_LOADER: ${{ needs.initialize.outputs.evergreen_loader }}
ON_DEVICE_TEST_ATTEMPTS: ${{ needs.initialize.outputs.on_device_test_attempts }}
MODULAR_BUILD: ${{ inputs.modular && 1 || 0 }}
# timeout-minutes: TODO: Not setting it here, depends on lab capacity
steps:
- name: Checkout
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -367,6 +372,7 @@ jobs:
HOME: /root
COBALT_EVERGREEN_LOADER: ${{needs.initialize.outputs.evergreen_loader}}
MODULAR_BUILD: ${{ inputs.modular && 1 || 0 }}
timeout-minutes: 90
steps:
- name: Checkout
uses: kaidokert/[email protected]
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/main_win.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
github.event.label.name == 'runtest' ||
github.event.label.name == 'on_device'
)
timeout-minutes: 10
steps:
- id: Checkout
uses: kaidokert/[email protected] # Temporary version
Expand Down Expand Up @@ -133,6 +134,7 @@ jobs:
permissions:
packages: write
runs-on: windows-2019
timeout-minutes: 60
steps:
- name: Checkout files
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -167,6 +169,7 @@ jobs:
platform: ${{ fromJson(needs.initialize.outputs.platforms) }}
include: ${{ fromJson(needs.initialize.outputs.includes) }}
config: [devel, debug, qa, gold]
timeout-minutes: 90
steps:
- name: Checkout
uses: kaidokert/[email protected]
Expand Down Expand Up @@ -204,6 +207,7 @@ jobs:
include: ${{ fromJson(needs.initialize.outputs.includes) }}
env:
MODULAR_BUILD: ${{ inputs.modular && 1 || 0 }}
timeout-minutes: 90
steps:
- name: Checkout
uses: kaidokert/[email protected]
Expand Down

0 comments on commit 001cb0e

Please sign in to comment.