Skip to content

Commit

Permalink
Rename variable
Browse files Browse the repository at this point in the history
  • Loading branch information
osagie98 committed Oct 3, 2024
1 parent a16cd86 commit 0eed20f
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class ResourceOverlay {

@SuppressWarnings("MemberName")
@UsedByNative
public final int garbage_collection_duration_threshold;
public final int buffer_garbage_collection_duration_threshold;

public ResourceOverlay(Context context) {
// Load the values for all Overlay variables.
Expand All @@ -48,7 +48,7 @@ public ResourceOverlay(Context context) {
context.getResources().getInteger(R.integer.max_video_buffer_budget);
this.min_audio_sink_buffer_size_in_frames =
context.getResources().getInteger(R.integer.min_audio_sink_buffer_size_in_frames);
this.garbage_collection_duration_threshold =
context.getResources().getInteger(R.integer.garbage_collection_duration_threshold);
this.buffer_garbage_collection_duration_threshold =
context.getResources().getInteger(R.integer.buffer_garbage_collection_duration_threshold);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
SbMediaGetBufferGarbageCollectionDurationThreshold() will be set to this
value. Set to 0 to use the default value.
-->
<item type="integer" name="garbage_collection_duration_threshold" />
<item type="integer" name="buffer_garbage_collection_duration_threshold" />
</policy>
</overlayable>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
SbMediaGetBufferGarbageCollectionDurationThreshold() will be set to this
value. Set to 0 to use the default value.
-->
<integer name="garbage_collection_duration_threshold"
<integer name="buffer_garbage_collection_duration_threshold"
tools:ignore="DuplicateDefinition">0</integer>

</resources>
2 changes: 1 addition & 1 deletion starboard/android/examples/overlays/res/xml/overlays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@
SbMediaGetBufferGarbageCollectionDurationThreshold() will be set to this
value. Set to 0 to use the default value.
-->
<item target="long/garbage_collection_duration_threshold" value="0" />
<item target="long/buffer_garbage_collection_duration_threshold" value="0" />
</overlay>
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
int64_t SbMediaGetBufferGarbageCollectionDurationThreshold() {
const int64_t overlayed_threshold =
starboard::android::shared::ApplicationAndroid::Get()
->GetOverlayedIntValue("garbage_collection_duration_threshold");
->GetOverlayedIntValue(
"buffer_garbage_collection_duration_threshold");
if (overlayed_threshold != 0) {
return overlayed_threshold;
}
Expand Down

0 comments on commit 0eed20f

Please sign in to comment.