-
Notifications
You must be signed in to change notification settings - Fork 116
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Add blocking toggle to SetPersistentSettings to wait for CommitPendingWrite() to complete. Greatly improves reliability and accuracy of persistent_settings_test especially now that sleep can be removed. Added blocking toggle to RemovePersistentSettings as well. Replaces ASSERT with EXPECT when inside of closures that depend on test_done.Signal() to avoid deadlocking. b/280430510 b/283529011 (cherry picked from commit e024a33) Co-authored-by: Brian Ting <[email protected]>
- Loading branch information
1 parent
b1cd4de
commit 3eeba6d
Showing
3 changed files
with
116 additions
and
103 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.