Make nplb part of default target

Change-Id: I433a8b7d4bd8054600c74daa12180ada11a443bc
youtube · Aug 30, 2024 · 4a81f52 · 4a81f52
1 parent 80ce1ba
commit 4a81f52
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 12 deletions.
diff --git a/starboard/BUILD.gn b/starboard/BUILD.gn
@@ -28,7 +28,6 @@ group("gn_all") {
     "//starboard/examples/hello_world:starboard_hello_world_example",
     "//starboard/examples/window:starboard_window_example",
     "//starboard/extension:extension_test",
-    "//starboard/nplb",
   ]
   if (sb_is_evergreen_compatible && current_toolchain == starboard_toolchain) {
     deps += [ "//starboard/nplb/nplb_evergreen_compat_tests" ]
@@ -100,6 +99,7 @@ group("gn_all") {
 group("default") {
   deps = [
     ":starboard_group",
+    "//starboard/nplb",
     "//starboard/tools:build_app_launcher_zip",
   ]
 }

diff --git a/starboard/nplb/BUILD.gn b/starboard/nplb/BUILD.gn
@@ -15,10 +15,10 @@
 import("//starboard/build/config/os_definitions.gni")
 
 target(gtest_target_type, "nplb") {
-  testonly = true
-
   sources = [
     "//starboard/common/test_main.cc",
+    "//starboard/common/thread.cc",
+    "//starboard/common/thread.h",
     "//starboard/nplb/sabi/alignment_test.cc",
     "//starboard/nplb/sabi/endianness_test.cc",
     "//starboard/nplb/sabi/signedness_and_size_of_enum_test.cc",

diff --git a/testing/gmock/BUILD.gn b/testing/gmock/BUILD.gn
@@ -7,7 +7,6 @@
 # into //third_party/googletest.
 
 source_set("gmock") {
-  testonly = true
   sources = [
     "include/gmock/gmock-actions.h",
     "include/gmock/gmock-matchers.h",
@@ -20,6 +19,5 @@ source_set("gmock") {
 # it stabilizes, Chromium code MUST use this target instead of reaching directly
 # into //third_party/googletest.
 source_set("gmock_main") {
-  testonly = true
   deps = [ "//third_party/googletest:gmock_main" ]
 }
diff --git a/testing/gtest/BUILD.gn b/testing/gtest/BUILD.gn
@@ -18,17 +18,14 @@ config("gtest_direct_config") {
 # it stabilizes, Chromium code MUST use this target instead of reaching directly
 # into //third_party/googletest.
 static_library("gtest") {
-  testonly = true
+
 
   sources = [
     "include/gtest/gtest-death-test.h",
     "include/gtest/gtest-message.h",
     "include/gtest/gtest-param-test.h",
     "include/gtest/gtest-spi.h",
     "include/gtest/gtest.h",
-
-
-
     "include/gtest/gtest_prod.h",
 
     # This is a workaround for the issues below.

diff --git a/third_party/googletest/BUILD.gn b/third_party/googletest/BUILD.gn
@@ -63,7 +63,6 @@ config("gmock_config") {
 # Do NOT depend on this directly. Use //testing/gtest instead.
 # See README.chromium for details.
 source_set("gtest") {
-  testonly = true
   sources = [
     # "custom/gtest/internal/custom/gtest.h",
     # "custom/gtest/internal/custom/stack_trace_getter.cc",
@@ -171,7 +170,6 @@ source_set("gtest_main") {
 # Do NOT depend on this directly. Use //testing/gmock instead.
 # See README.chromium for details.
 source_set("gmock") {
-  testonly = true
   sources = [
     "src/googlemock/include/gmock/gmock-actions.h",
     "src/googlemock/include/gmock/gmock-cardinalities.h",
@@ -205,7 +203,6 @@ source_set("gmock") {
 # Do NOT depend on this directly. Use //testing/gmock:gmock_main instead.
 # See README.chromium for details.
 static_library("gmock_main") {
-  testonly = true
   sources = [ "src/googlemock/src/gmock_main.cc" ]
   deps = [ ":gmock" ]
 }