Remove STACK_ALIGN_OVER_16_BYTES from Starboard (#2748)

This appears no longer used. b/150410605
youtube · Mar 29, 2024 · 4ad1eef · 4ad1eef
2 parents 7073a79 + 66db178
commit 4ad1eef
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 31 deletions.
diff --git a/cobalt/site/docs/reference/starboard/configuration-public.md b/cobalt/site/docs/reference/starboard/configuration-public.md
@@ -3,13 +3,6 @@ Book: /youtube/cobalt/_book.yaml
 
 # Starboard Configuration Reference Guide
 
-## Architecture Configuration
-
-| Properties |
-| :--- |
-| **`SB_HAS_QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES`**<br><br>Some platforms will not align variables on the stack with an alignment greater than 16 bytes. Platforms where this is the case should define the following quirk.<br><br>By default, this property is undefined. |
-
-
 ## Compiler Configuration
 
 | Properties |

diff --git a/starboard/CHANGELOG.md b/starboard/CHANGELOG.md
@@ -9,6 +9,9 @@ since the version previous to it.
 
 ## Version 16
 
+## Removed `QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES`
+This configuration is not used in Cobalt.
+
 ## Removed `QUIRK_SOCKET_BSD_HEADERS` configuration
 This config flag is unused.
 

diff --git a/starboard/android/shared/configuration_public.h b/starboard/android/shared/configuration_public.h
@@ -100,10 +100,4 @@
 #error "Android builds need a GCC-like compiler (for the moment)."
 #endif
 
-// --- Platform Specific Quirks ----------------------------------------------
-
-// Indicates that there is no support for alignment at greater than 16 bytes for
-// items on the stack.
-#define SB_HAS_QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES 1
-
 #endif  // STARBOARD_ANDROID_SHARED_CONFIGURATION_PUBLIC_H_
diff --git a/starboard/evergreen/arm64/configuration_public.h b/starboard/evergreen/arm64/configuration_public.h
@@ -104,10 +104,4 @@
 #error "Evergreen-arm64 builds need a GCC-like compiler (for the moment)."
 #endif
 
-// --- Platform Specific Quirks ----------------------------------------------
-
-// Indicates that there is no support for alignment at greater than 16 bytes for
-// items on the stack.
-#define SB_HAS_QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES 1
-
 #endif  // STARBOARD_EVERGREEN_ARM64_CONFIGURATION_PUBLIC_H_
diff --git a/starboard/nplb/align_test.cc b/starboard/nplb/align_test.cc
@@ -100,7 +100,6 @@ TEST(SbAlignTest, AlignAsStackVariable) {
   EXPECT_LE(8, GetAlignment(&by_8));
   EXPECT_LE(16, GetAlignment(&by_16));
 
-#if !SB_HAS_QUIRK(DOES_NOT_STACK_ALIGN_OVER_16_BYTES)
   SB_ALIGNAS(32) char by_32;
   char unaligned6 = 6;
   EXPECT_NE(unaligned6, unaligned1);
@@ -118,7 +117,6 @@ TEST(SbAlignTest, AlignAsStackVariable) {
   EXPECT_LE(64, GetAlignment(&by_64));
   EXPECT_LE(128, GetAlignment(&by_128));
   EXPECT_LE(256, GetAlignment(&by_256));
-#endif  // !SB_HAS_QUIRK(DOES_NOT_STACK_ALIGN_OVER_16_BYTES)
 }
 
 TEST(SbAlignTest, AlignOf) {

diff --git a/starboard/raspi/shared/configuration_public.h b/starboard/raspi/shared/configuration_public.h
@@ -103,7 +103,4 @@
 // by over 16 bytes.
 #define SB_HAS_QUIRK_DOES_NOT_ALIGN_FIELDS_IN_HEAP_OVER_16_BYTES 1
 
-// The Raspberry Pi does not apparently align stack variables by over 16 bytes.
-#define SB_HAS_QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES 1
-
 #endif  // STARBOARD_RASPI_SHARED_CONFIGURATION_PUBLIC_H_
diff --git a/starboard/stub/configuration_public.h b/starboard/stub/configuration_public.h
@@ -22,13 +22,6 @@
 #ifndef STARBOARD_STUB_CONFIGURATION_PUBLIC_H_
 #define STARBOARD_STUB_CONFIGURATION_PUBLIC_H_
 
-// --- Architecture Configuration --------------------------------------------
-
-// Some platforms will not align variables on the stack with an alignment
-// greater than 16 bytes. Platforms where this is the case should define the
-// following quirk.
-#undef SB_HAS_QUIRK_DOES_NOT_STACK_ALIGN_OVER_16_BYTES
-
 // --- System Header Configuration -------------------------------------------
 
 // Any system headers listed here that are not provided by the platform will be