Skip to content

Commit

Permalink
Remove DeployPathPatterns (#2703)
Browse files Browse the repository at this point in the history
DeployPathPatterns are unused in packaging and deployment scripts.

b/150410605
  • Loading branch information
kaidokert authored Mar 25, 2024
2 parents 402e3e5 + f397ea5 commit 60884cb
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
4 changes: 0 additions & 4 deletions starboard/android/shared/gyp_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ def __init__(self, platform):
super().__init__(platform)
self.AppendApplicationConfigurationPath(os.path.dirname(__file__))

def GetDeployPathPatterns(self):
# example src/out/android-arm64/devel/cobalt.apk
return ['*.apk']

def GetLauncher(self):
"""Gets the module used to launch applications on this platform."""
module_path = os.path.abspath(
Expand Down
12 changes: 0 additions & 12 deletions starboard/build/platform_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,6 @@ def GetTestEnvVariables(self):
"""Gets a dict of environment variables needed by unit test binaries."""
return {}

def GetDeployPathPatterns(self):
"""Gets deployment paths patterns for files to be included for deployment.
Example: ['deploy/*.exe', 'content/*']
Returns:
A list of path wildcard patterns within the PRODUCT_DIR
(src/out/<PLATFORM>_<CONFIG>) that need to be deployed in order for the
platform launcher to run target executable(s).
"""
raise NotImplementedError()

def GetTestTargets(self):
"""Gets all tests to be run in a unit test run.
Expand Down
4 changes: 0 additions & 4 deletions starboard/xb1/gyp_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,3 @@ def GetLauncher(self):
os.path.join(os.path.dirname(__file__), 'launcher.py'))
launcher_module = imp.load_source('launcher', module_path)
return launcher_module

def GetDeployPathPatterns(self):
"""example src/out/xb1_devel/appx"""
return ['appx/*'] # Overinclude

0 comments on commit 60884cb

Please sign in to comment.