Fix crash caused by Use after free

b/329330347
youtube · Mar 14, 2024 · 6f95614 · 6f95614
1 parent c65b33a
commit 6f95614
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cobalt/media_session/media_session_client.cc b/cobalt/media_session/media_session_client.cc
@@ -331,15 +331,15 @@ void MediaSessionClient::OnMediaSessionStateChanged(
         for (MediaImageSequence::size_type i = 0; i < artwork_size; i++) {
           const MediaImage& media_image(artwork.at(i));
           CobaltExtensionMediaImage ext_image;
-          ext_image.src = media_image.src().c_str();
+          ext_image.src = std::string(media_image.src()).c_str();
           if (ext_image.src == nullptr) {
             // src() is required, but Cobalt IDL parser doesn't enforce it.
             // See cobalt/media_session/media_image.idl for more info.
             // https://wicg.github.io/mediasession/#dictdef-mediaimage
             LOG(ERROR) << "Required src string for MediaImage is missing.";
           }
-          ext_image.size = media_image.sizes().c_str();
-          ext_image.type = media_image.type().c_str();
+          ext_image.size = std::string(media_image.sizes()).c_str();
+          ext_image.type = std::string(media_image.type()).c_str();
           ext_artwork[i] = ext_image;
         }
       }