Cherry pick PR #3465: [XB1] Truncate protocol name in the AppxManifest (

#3658) Refer to the original PR: #3465 Microsoft limits the uap:Protocol Name attribute to 39 characters. Truncate this when generating the AppxManifest if it would be longer. b/345279618 Change-Id: I4eab4cbd8d42ec6c767164a1e9c91b54bc85b62c Co-authored-by: Tyler Holcombe <[email protected]>
youtube · Jun 24, 2024 · 7b3e454 · 7b3e454
1 parent 9b2d902
commit 7b3e454
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/starboard/xb1/templates/ApplicationSection.xml.template b/starboard/xb1/templates/ApplicationSection.xml.template
@@ -42,7 +42,8 @@
     </uap:Extension>
     {% endif %}
     <uap:Extension Category="windows.protocol">
-      <uap:Protocol Name="{{ __APPLICATION_NAME__|replace('_','-') }}-starboard"/>
+      {# Truncating because MS set the max length of Protocol Name to 39 characters. #}
+      <uap:Protocol Name="{{ __APPLICATION_NAME__|replace('_','-')|truncate(29,False,'') }}-starboard"/>
     </uap:Extension>
     {% endif %}
   </Extensions>

diff --git a/starboard/xb1/test_filters.py b/starboard/xb1/test_filters.py
@@ -51,6 +51,7 @@
         'VideoDecoderTests/VideoDecoderTest.ResetBeforeInput/beneath_the_canopy_248_vp9_dmp_DecodeToTexture',
         'VideoDecoderTests/VideoDecoderTest.MultipleResets/beneath_the_canopy_248_vp9_dmp_DecodeToTexture',
     ],
+    'trace_processor_minimal_smoke_tests': ['StorageMinimalSmokeTest/*',],
 }