Add flag for partial audio frame support (#2860)

Allow Starboard implementations to turn partial audio frames off. b/324905656 (cherry picked from commit deb633e)
youtube · Jun 4, 2024 · 7d23d6f · 7d23d6f
1 parent 1636824
commit 7d23d6f
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 0 deletions.
diff --git a/starboard/CHANGELOG.md b/starboard/CHANGELOG.md
@@ -9,6 +9,9 @@ since the version previous to it.
 
 ## Version 16
 
+## Added new configuration constant `kHasPartialAudioFramesSupport`
+Set this to true if your platform supports partial audio frames.
+
 ### Deprecated `SbMutex`, `SbConditionVariable` and `SbThread`.
 The standard POSIX `pthread` APIs replace the Starboard concurrency
 primitives.

diff --git a/starboard/android/shared/configuration_constants.cc b/starboard/android/shared/configuration_constants.cc
@@ -142,4 +142,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = true;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = true;
 #endif
diff --git a/starboard/configuration_constants.h b/starboard/configuration_constants.h
@@ -157,6 +157,9 @@ SB_EXPORT extern const uint32_t kSbMaxSystemPathCacheDirectorySize;
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport;
 #endif
 
 #endif  // STARBOARD_CONFIGURATION_CONSTANTS_H_
diff --git a/starboard/elf_loader/exported_symbols.cc b/starboard/elf_loader/exported_symbols.cc
@@ -118,6 +118,7 @@ ExportedSymbols::ExportedSymbols() {
 #endif  // SB_API_VERSION < 16
 #if SB_API_VERSION >= 16
   REGISTER_SYMBOL(kSbCanMapExecutableMemory);
+  REGISTER_SYMBOL(kHasPartialAudioFramesSupport);
 #endif
   REGISTER_SYMBOL(SbAccessibilityGetCaptionSettings);
   REGISTER_SYMBOL(SbAccessibilityGetDisplaySettings);

diff --git a/starboard/linux/shared/configuration_constants.cc b/starboard/linux/shared/configuration_constants.cc
@@ -139,4 +139,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 
 #if SB_API_VERSION >= 16
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = true;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = true;
 #endif
diff --git a/starboard/nplb/player_test_util.cc b/starboard/nplb/player_test_util.cc
@@ -402,7 +402,11 @@ bool IsOutputModeSupported(SbPlayerOutputMode output_mode,
 
 bool IsPartialAudioSupported() {
 #if SB_API_VERSION >= 15
+#if SB_API_VERSION >= 16
+  return kHasPartialAudioFramesSupport;
+#else
   return true;
+#endif
 #else   // SB_API_VERSION >= 15
   return SbSystemGetExtension(kCobaltExtensionEnhancedAudioName) != nullptr;
 #endif  // SB_API_VERSION >= 15

diff --git a/starboard/raspi/shared/configuration_constants.cc b/starboard/raspi/shared/configuration_constants.cc
@@ -143,4 +143,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = true;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = true;
 #endif
diff --git a/starboard/stub/configuration_constants.cc b/starboard/stub/configuration_constants.cc
@@ -140,4 +140,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = false;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = false;
 #endif
diff --git a/starboard/win/shared/configuration_constants.cc b/starboard/win/shared/configuration_constants.cc
@@ -149,4 +149,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = true;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = true;
 #endif
diff --git a/starboard/xb1/shared/configuration_constants.cc b/starboard/xb1/shared/configuration_constants.cc
@@ -146,4 +146,7 @@ const uint32_t kSbMaxSystemPathCacheDirectorySize = 24 << 20;  // 24MiB
 // Whether this platform can map executable memory. This is required for
 // platforms that want to JIT.
 SB_EXPORT extern const bool kSbCanMapExecutableMemory = true;
+
+// Platform can support partial audio frames
+SB_EXPORT extern const bool kHasPartialAudioFramesSupport = true;
 #endif