Skip to content

Commit

Permalink
Clean up unused test filter 'config'
Browse files Browse the repository at this point in the history
We only run tests on CI in 'devel' config, so removing filters in
'debug' mode is a no-op.

b/150410605
  • Loading branch information
kaidokert committed Mar 25, 2024
1 parent a652624 commit 7e4790e
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 26 deletions.
5 changes: 0 additions & 5 deletions starboard/evergreen/arm/shared/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ def __init__( # pylint:disable=useless-super-delegation

def GetTestFilters(self):
filters = super().GetTestFilters()
filters.extend([
# TODO: Remove this filter once the layout_tests slowdown in the debug
# configuration is resolved.
test_filter.TestFilter('layout_tests', test_filter.FILTER_ALL, 'debug'),
])
for target, tests in self.__FILTERED_TESTS.items():
filters.extend(test_filter.TestFilter(target, test) for test in tests)
return filters
Expand Down
4 changes: 0 additions & 4 deletions starboard/evergreen/arm/shared/gyp_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,3 @@ def __init__(self, platform):
super().__init__(platform)

self.AppendApplicationConfigurationPath(os.path.dirname(__file__))


def CreatePlatformConfig():
return EvergreenArmConfiguration('evergreen-arm')
10 changes: 1 addition & 9 deletions starboard/linux/shared/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,7 @@ def GetWebPlatformTestFilters(self):
# These tests are timing-sensitive, and are thus flaky on slower builds
test_filter.TestFilter(
'web_platform_tests',
'xhr/WebPlatformTest.Run/XMLHttpRequest_send_timeout_events_htm',
'debug'),
test_filter.TestFilter(
'web_platform_tests',
'streams/WebPlatformTest.Run/streams_readable_streams_templated_html', # pylint:disable=line-too-long
'debug'),
test_filter.TestFilter(
'web_platform_tests',
'cors/WebPlatformTest.Run/cors_preflight_failure_htm', 'devel')
'cors/WebPlatformTest.Run/cors_preflight_failure_htm')
])
return filters

Expand Down
3 changes: 0 additions & 3 deletions starboard/raspi/shared/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ class CobaltRaspiConfiguration(cobalt_configuration.CobaltConfiguration):
def GetTestFilters(self):
filters = super().GetTestFilters()
filters.extend([
# TODO: Remove this filter once the layout_tests slowdown in the debug
# configuration is resolved.
test_filter.TestFilter('layout_tests', test_filter.FILTER_ALL, 'debug'),
# These tests are currently producing slightly different images on the
# RasPi.
test_filter.TestFilter('renderer_test',
Expand Down
6 changes: 1 addition & 5 deletions starboard/tools/testing/test_filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,8 @@ class TestFilter(object):
target_name: The name of the unit test binary from which to remove tests.
test_name: The name of a specific test from the provided test target, or a
constant from this module defining a group of tests to filter.
config: An optional argument specifying for which build configuration
the test should be excluded. If this name is not provided, the test
will be excluded from all test runs.
"""

def __init__(self, target_name, test_name, config=None):
def __init__(self, target_name, test_name):
self.target_name = target_name
self.test_name = test_name
self.config = config

0 comments on commit 7e4790e

Please sign in to comment.