Cherry pick PR #2608: [media] Remove capability change media error (#…

…2677) Refer to the original PR: #2608 Removes "MEDIA_ERR_CAPABILITY_CHANGED" from the MediaError interface. Also removes "PLAYBACK_CAPABILITY_CHANGED" from PipelineStatus histograms. b/321844872 Co-authored-by: Austin Osagie <[email protected]>
youtube · Apr 8, 2024 · 9335b3b · 9335b3b
1 parent 07c292d
commit 9335b3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cobalt/dom/media_error.idl b/cobalt/dom/media_error.idl
@@ -20,8 +20,8 @@ interface MediaError {
   const unsigned short MEDIA_ERR_DECODE = 3;
   const unsigned short MEDIA_ERR_SRC_NOT_SUPPORTED = 4;
   const unsigned short MEDIA_ERR_ENCRYPTED = 5;
-  // The underlying playback capability has changed, the app should treat this
-  // as a transient error and retry playback.
+  // Deprecated. Capability change errors are reported with
+  // code MEDIA_ERR_DECODE.
   const unsigned short MEDIA_ERR_CAPABILITY_CHANGED = 1000;
 
   readonly attribute unsigned short code;

diff --git a/tools/metrics/histograms/metadata/cobalt/enums.xml b/tools/metrics/histograms/metadata/cobalt/enums.xml
@@ -65,7 +65,9 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra
   <int value="21" label="PIPELINE_ERROR_EXTERNAL_RENDERER_FAILED"/>
   <int value="22" label="DEMUXER_ERROR_DETECTED_HLS"/>
   <int value="23" label="PIPELINE_ERROR_HARDWARE_CONTEXT_RESET"/>
-  <int value="24" label="PLAYBACK_CAPABILITY_CHANGED"/>
+  <!-- Deprecated. Capability change errors are reported with
+       PIPELINE_ERROR_DECODE  -->
+  <int value="24" label="PLAYBACK_CAPABILITY_CHANGED (deprecated)"/>
 </enum>